Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(metrics): Use modified moving average for topic metrics speed #3808

Merged
merged 2 commits into from
Nov 12, 2020
Merged

refactor(metrics): Use modified moving average for topic metrics speed #3808

merged 2 commits into from
Nov 12, 2020

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Nov 2, 2020 •
edited
Loading

this PR fixes (partially) #3788

@zmstone
Copy link
Member Author

zmstone commented Nov 3, 2020

Looks good to me.
The new stats are not exposed though.
Please add exposure in a follow up PR.

@zmstone
Copy link
Member Author

zmstone commented Nov 4, 2020

the numbers are to be exposed from a gen_server:call in similar APIs like last/1

@ayo-dele-akin ayo-dele-akin force-pushed the improve-speed-average branch 3 times, most recently from c5fd1b8 to 172d12e Compare November 5, 2020 22:58
@ayo-dele-akin ayo-dele-akin force-pushed the improve-speed-average branch 4 times, most recently from 85a100d to 77c0f2a Compare November 6, 2020 09:28
@ayo-dele-akin ayo-dele-akin force-pushed the improve-speed-average branch 3 times, most recently from d9be65c to dec75c9 Compare November 9, 2020 14:09
@zmstone zmstone changed the base branch from master to dev/v5.0 November 9, 2020 19:22
@ayo-dele-akin ayo-dele-akin force-pushed the improve-speed-average branch 2 times, most recently from f262d3d to 53de4a2 Compare November 9, 2020 19:40
@ayo-dele-akin ayo-dele-akin force-pushed the improve-speed-average branch 3 times, most recently from 66b8393 to 4abe539 Compare November 12, 2020 11:28
@zmstone zmstone merged commit 380c874 into emqx:dev/v5.0 Nov 12, 2020
@zmstone zmstone deleted the improve-speed-average branch November 12, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigercl tigercl tigercl approved these changes

@ayo-dele-akin ayo-dele-akin ayo-dele-akin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmstone @ayo-dele-akin @tigercl