chore(CI): cancel build of 32-bit docker #5144
Conversation
|
I will make a PR for emqx to disable quic build in rebar3 script so the quic support will be disabled on these platforms. With that emqx can stil deliver packages for these platforms while only the quic support function will be missing. |
Yes, it's a great feature, but I think we should try to make sure that the published images are consistent Users can build their own images on a 32-bit system that does not support quic |
|
I fixed the 32bit build of quicer but now the problem is the docker image needs a compiler upgrade to gcc 5 or above. We are using alpine-i386 for compiling i386 images, can we switch it to something else? like centos7 32bit or ubuntu 32bit? |
We need to use alpine as base image because we want to minimize the size of the docker If gcc5 cannot be installed on alpine 386, I think we can discard the support for 386 s390x I think we can give up support, we just need to support amd64, arm64, and arm32v7 |
Rory-Z
force-pushed
the
chore/cancel-build-of-32-bit-docker
branch
from
034fe11
to
1c6447e
Compare
| @@ -218,7 +218,7 @@ jobs: | |||
| os: | |||
| - ubuntu20.04 | |||
| - ubuntu18.04 | |||
| - ubuntu16.04 | |||
There was a problem hiding this comment.
I have tested that quic can build on 16.04
| @@ -341,14 +341,6 @@ jobs: | |||
| arch: | |||
| - [amd64, x86_64] | |||
| - [arm64v8, aarch64] | |||
| - [arm32v7, arm] | |||
There was a problem hiding this comment.
Worth to keep it? Since quicer can support it and the majority of raspberrypi are running this arch I think.
There was a problem hiding this comment.
If the quic can support armv7, let's keep it
|
See also: #5144 |
Rory-Z
force-pushed
the
chore/cancel-build-of-32-bit-docker
branch
from
1c6447e
to
bfa6025
Compare
@turtleDeng @tigercl @zmstone @qzhuyan @wivwiv
Quic does not support 32-bit builds, do we still need to continue to support 32-bit docker images ?