refactor: simplify ci scripts #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to su before start
zmstone
force-pushed
the
refactor-simplify-ci-scripts
branch
4 times, most recently
from
82229cf
to
709655d
Compare
qzhuyan
reviewed
Aug 8, 2021
| WAIT_TIME="$1" | ||
| shift | ||
| CMD="$*" | ||
| while true; do |
There was a problem hiding this comment.
can bash timeout help here?
There was a problem hiding this comment.
it's a command which may not exist in e.g. macos?
also here the probes don't really take a long time, but it's sleep.
and timeout can not be used on bash functions, only commands
qzhuyan
reviewed
Aug 8, 2021
qzhuyan
reviewed
Aug 8, 2021
qzhuyan
reviewed
Aug 8, 2021
Rory-Z
previously approved these changes
Aug 9, 2021
zmstone
force-pushed
the
refactor-simplify-ci-scripts
branch
from
709655d
to
f1262e0
Compare
|
squashed fixes. |
qzhuyan
approved these changes
Aug 9, 2021
Rory-Z
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.