fix(authn): authn http is_superuser field
#8374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigercl
reviewed
Jul 1, 2022
HJianBo
reviewed
Jul 1, 2022
tigercl
reviewed
Jul 1, 2022
JimMoen
force-pushed
the
fix-authn-http
branch
4 times, most recently
from
9c4b120
to
ae411ad
Compare
JimMoen
force-pushed
the
fix-authn-http
branch
4 times, most recently
from
25bf8fa
to
e31d2e6
Compare
only support true|false|[num] and for [num]: zero => false | non-zero => true other type and string will fallback to default vaule => false i.e null|undefined|[empty string]
tigercl
approved these changes
Jul 1, 2022
zmstone
reviewed
Jul 1, 2022
| <<"ignore">> -> | ||
| ignore; | ||
| _ -> | ||
| ignore |
There was a problem hiding this comment.
This breaks backward compatibility?
|
Ha changing my app's response to |
|
@atlantis cool, I can confirm that also returning 204 with no content works properly. EMQX Team Please update the docs. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.