Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authn): authn http is_superuser field #8374

Merged
merged 4 commits into from
Jul 1, 2022

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Jul 1, 2022

No description provided.

@JimMoen JimMoen force-pushed the fix-authn-http branch 4 times, most recently from 9c4b120 to ae411ad Compare July 1, 2022 10:07
@tigercl tigercl marked this pull request as ready for review July 1, 2022 10:45
@JimMoen JimMoen force-pushed the fix-authn-http branch 4 times, most recently from 25bf8fa to e31d2e6 Compare July 1, 2022 12:30
only support true|false|[num]
and for [num]: zero => false | non-zero => true

other type and string will fallback to default vaule => false
i.e null|undefined|[empty string]
@tigercl tigercl merged commit 8d4907e into emqx:master Jul 1, 2022
<<"ignore">> ->
ignore;
_ ->
ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks backward compatibility?

@atlantis
Copy link

atlantis commented Jul 1, 2022

Ha changing my app's response to {"result": "allow"} did in fact fix this issue thanks!

@dsilletti
Copy link

@atlantis cool, I can confirm that also returning 204 with no content works properly.

EMQX Team Please update the docs.

Thank you.

@JimMoen JimMoen deleted the fix-authn-http branch July 4, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants