Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop then start listener #205

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Aug 22, 2023

Improve listener API,

  • add API to stop and restart the listener with Listener handle
  • fix config resource leaks in listener
  • rename start_listener to spawn listener for supervised listener
  • rename stop_listener to terminate listener for supervised listener

also fix config resource leaks in listener
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5939009032

  • 70 of 86 (81.4%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 82.795%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/quicer.erl 13 14 92.86%
src/quicer_nif.erl 0 2 0.0%
c_src/quicer_listener.c 52 65 80.0%
Files with Coverage Reduction New Missed Lines %
src/quicer_stream.erl 1 72.22%
c_src/quicer_nif.c 4 76.92%
Totals Coverage Status
Change from base Build 5936455597: -0.2%
Covered Lines: 2897
Relevant Lines: 3499

💛 - Coveralls

c_src/quicer_listener.c Show resolved Hide resolved
@qzhuyan qzhuyan merged commit bd633e2 into emqx:main Aug 22, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants