Dev/william/connection registrations #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/connection-registrations
branch
from
7970e77
to
b69b723
Compare
qzhuyan
force-pushed
the
dev/william/connection-registrations
branch
from
649c81b
to
c46fe87
Compare
- parse_conn_local_address - parse_conn_resume_ticket - parse_conn_disable_1rtt_encryption - parse_conn_event_mask
msquic does conn callback with StreamsAvailable event in the same code
path of set conn param session ticket.
This causes deadlock when callback handler wait for quicer async_connect to
release the lock of c_ctx when it is called with an opened handle.
solution is to either do set session ticket in open_connection
Or set session ticket in async_connect without an opened handle
callstack:
at /home/ubuntu/repo/quic/msquic/src/core/stream_set.c:343
qzhuyan
force-pushed
the
dev/william/connection-registrations
branch
from
c46fe87
to
6f047c7
Compare
Pull Request Test Coverage Report for Build 6182265711
💛 - Coveralls |
thalesmg
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup: #215,
client can create connection with registration
and some refactorings