API synchronization #225
Merged
API synchronization #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
from
fdf39fd
to
bdc66c8
Compare
qzhuyan
force-pushed
the
dev/william/nif-module-reload
branch
from
bdc66c8
to
97979b5
Compare
zmstone
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: follow up thread safe API in #222
Changes in #222 decouples the ctx lifetime and handle lifetime that the C handle life can be shorter than ctx thus we must have some synchronization in APIs. We use refcnt for tracking the lifetime of the C handle and use mutex for protecting critical section.