-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing release script #227
Conversation
CMakeLists.txt
Outdated
@@ -83,7 +83,7 @@ set(QUIC_TLS_SECRETS_SUPPORT "ON") | |||
|
|||
configure_file( | |||
${CMAKE_CURRENT_SOURCE_DIR}/include/quicer_vsn.hrl.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the .hrl.in file should not be in include
dir, maybe put it in another directory which is not going to be packed into a hex package.
q: why don't generate the hrl file and commit to git |
It is the same I think, or? EMQX forked rebar3 copies the src to better idea? |
Pull Request Test Coverage Report for Build 6786564350
💛 - Coveralls |
in case of cache miss
After discuss with Stone, I agree commit generated hrl file to git makes release process much formal. |
No description provided.