Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing release script #227

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Nov 6, 2023

No description provided.

CMakeLists.txt Outdated
@@ -83,7 +83,7 @@ set(QUIC_TLS_SECRETS_SUPPORT "ON")

configure_file(
${CMAKE_CURRENT_SOURCE_DIR}/include/quicer_vsn.hrl.in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .hrl.in file should not be in include dir, maybe put it in another directory which is not going to be packed into a hex package.

@zmstone
Copy link
Member

zmstone commented Nov 6, 2023

q: why don't generate the hrl file and commit to git

@qzhuyan
Copy link
Collaborator Author

qzhuyan commented Nov 7, 2023

q: why don't generate the hrl file and commit to git

It is the same I think, or?

EMQX forked rebar3 copies the src to _build before compile so it is risky that rebar3 uses the old committed file. because the hrl generation is executed in a pre-compile hook we need to copy the generated file to _build anyway. I had a similar issue while I was cheated to test old *.so file from the old build.

better idea?

@coveralls
Copy link

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6786564350

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 82.97%

Files with Coverage Reduction New Missed Lines %
src/quicer.erl 1 88.32%
src/quicer_nif.erl 1 27.42%
Totals Coverage Status
Change from base Build 6615274677: 0.07%
Covered Lines: 3347
Relevant Lines: 4034

💛 - Coveralls

thalesmg
thalesmg previously approved these changes Nov 7, 2023
in case of cache miss
@qzhuyan
Copy link
Collaborator Author

qzhuyan commented Nov 7, 2023

After discuss with Stone, I agree commit generated hrl file to git makes release process much formal.

@qzhuyan qzhuyan merged commit c63fd66 into emqx:main Nov 8, 2023
25 checks passed
@qzhuyan qzhuyan deleted the dev/william/update-packaging branch November 8, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants