Set cacertfile in tls ctx #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7280780192
💛 - Coveralls |
ieQu1
previously approved these changes
Dec 20, 2023
thalesmg
previously approved these changes
Dec 20, 2023
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| flag-name: run-c-lcov-feature |
There was a problem hiding this comment.
Just curiosity: is this flag defined somewhere in the codebase? I didn't find it. 🙈
There was a problem hiding this comment.
Just a name, let coverall knows it is different subtask or parallel job
qzhuyan
force-pushed
the
dev/william/cacertfile-in-tls-ctx
branch
from
c0af21f
to
3c1d892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #250
This is new feature in msquic 2.2.
Before this change certificate (chain) validation was done in the callback (quicer) , now it is done in TLS.
QUICER_USE_TRUSTED_STOREWe used to have trusted store cache in listener to speed up handshakes.