Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hanging registration close due to a race in listener stop/close #269

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: hanging registration close due to a race in listener stop/close #269

merged 1 commit into from
May 3, 2024

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented May 3, 2024 •
edited
Loading

fix the flaky test

@qzhuyan qzhuyan force-pushed the fix/william/race-listener-stop-close branch from 2276316 to 90b594e Compare May 3, 2024 12:32
@coveralls
Copy link

coveralls commented May 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8939011418

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 87.433%
Files with Coverage Reduction New Missed Lines %
c_src/quicer_config.c 7 90.2%
Totals Coverage Status
Change from base Build 8174019475: 0.05%
Covered Lines: 3778
Relevant Lines: 4321
💛 - Coveralls

@qzhuyan qzhuyan merged commit a4df078 into emqx:main May 3, 2024
24 checks passed
@qzhuyan qzhuyan deleted the fix/william/race-listener-stop-close branch October 21, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qzhuyan @coveralls @thalesmg