build: remove dup dyn lib files for EMQX build #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id
reviewed
Sep 20, 2024
| # so we dref at here to keep one dynlib file to avoid dup files in EMQX package | ||
| # - priv/libquicer_nif.so | ||
| # - priv/libquicer_nif.so.1 | ||
| # - priv/libquicer_nif.so.504 |
There was a problem hiding this comment.
it is already excluded from pkg.
id
approved these changes
Sep 20, 2024
Pull Request Test Coverage Report for Build 10956746046Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customer complains dup quicer .so files in EMQX package which wastes spaces.
Quicer deliver files with softlinks while rebar3 just deref them and copy….
I tried to modify EMQX build script, or rebar hooks but didn’t success.
I think it will be easier just do it from the quicer source.
Downside is it won't be upgradable.