Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser.safeSetTimeout fails to pass timeout interval setTimeout #17941

Closed
Neuhaus24 opened this issue Sep 29, 2022 · 0 comments · Fixed by #17946
Closed

Browser.safeSetTimeout fails to pass timeout interval setTimeout #17941

Neuhaus24 opened this issue Sep 29, 2022 · 0 comments · Fixed by #17946

Comments

@Neuhaus24
Copy link

Neuhaus24 commented Sep 29, 2022 •
edited
Loading

Compiling with emcc v3.1.16 with SDL2 included.

The compilation of SDL_AddTimer produces a timer that fails to wait any time before the callback fires because their implementation uses Browser.setSafeTimeout which doesn't pass the timeout interval through to the setTimeout call.

This appears to have been around since 607ca448f224bab0a223d60d2b7e2426df8b0d28
@Neuhaus24 Neuhaus24 mentioned this issue Sep 29, 2022
Closed
sbc100 added a commit to sbc100/SDL that referenced this issue Sep 29, 2022
@sbc100
emscripten: Remove use of EM_ASM from SDL_timer code.
3ea8b35 
Instead use the native emscripten timer API.

See emscripten-core/emscripten#17941
@sbc100 sbc100 mentioned this issue Sep 29, 2022
Merged
sbc100 added a commit that referenced this issue Sep 29, 2022
@sbc100
Fix SDL_AddTimer not honoring timeout argument
8771628 
Fixes: #17941
@sbc100 sbc100 mentioned this issue Sep 29, 2022
Merged
sbc100 added a commit that referenced this issue Sep 29, 2022
@sbc100
Fix SDL_AddTimer not honoring timeout argument
2d62f9a 
Fixes: #17941
sbc100 added a commit that referenced this issue Sep 29, 2022
@sbc100
Fix SDL_AddTimer not honoring timeout argument
4308adb 
Fixes: #17941
sbc100 added a commit that referenced this issue Sep 29, 2022
@sbc100
Fix SDL_AddTimer not honoring timeout argument (#17946)
320040f 
Fixes: #17941
sbc100 added a commit to sbc100/SDL that referenced this issue Sep 30, 2022
@sbc100
emscripten: Remove use of EM_ASM from SDL_timer code.
8f3e22d 
Instead use the native emscripten timer API.

See emscripten-core/emscripten#17941
sbc100 added a commit to sbc100/SDL that referenced this issue Sep 30, 2022
@sbc100
emscripten: Remove use of EM_ASM from SDL_timer code.
fdd0bf9 
Instead use the native emscripten timer API.

See emscripten-core/emscripten#17941
sbc100 added a commit to sbc100/SDL that referenced this issue Sep 30, 2022
@sbc100
emscripten: Remove use of EM_ASM from SDL_timer code.
ca35f09 
Instead use the native emscripten timer API.

See emscripten-core/emscripten#17941
icculus pushed a commit to libsdl-org/SDL that referenced this issue Sep 30, 2022
@sbc100 @icculus
emscripten: Remove use of EM_ASM from SDL_timer code.
cfab203 
Instead use the native emscripten timer API.

See emscripten-core/emscripten#17941
PJB3005 pushed a commit to PJB3005/SDL that referenced this issue Oct 5, 2022
@sbc100 @PJB3005
emscripten: Remove use of EM_ASM from SDL_timer code.
403fcf4 
Instead use the native emscripten timer API.

See emscripten-core/emscripten#17941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SDL_AddTimer not honoring timeout argument emscripten-core/emscripten
1 participant
@Neuhaus24