fix: handle mmap offset #10095
Merged
fix: handle mmap offset #10095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS. |
petersalomonsen
force-pushed
the
fix-mmap-offset
branch
from
4e3f05a
to
aaec9db
Compare
petersalomonsen
added a commit
to petersalomonsen/libgit2
that referenced
this pull request
Dec 22, 2019
add http transport for emscripten add example for git commit fix example for git add add synchronous http worker for nodejs add example for interacting with examples from emscripten depends on mmap offset fix in emscripten: emscripten-core/emscripten#10095
This was referenced Dec 22, 2019
Closed
petersalomonsen
added a commit
to petersalomonsen/libgit2
that referenced
this pull request
Dec 22, 2019
add http transport for emscripten add example for git commit fix example for git add add synchronous http worker for nodejs add web http support using sync XmlHttpRequest add nodejs and webworker examples for interacting with libgit2.js depends on mmap offset fix in emscripten: emscripten-core/emscripten#10095
petersalomonsen
added a commit
to petersalomonsen/libgit2
that referenced
this pull request
Dec 22, 2019
add http transport for emscripten add example for git commit fix example for git add add synchronous http worker for nodejs add web http support using sync XmlHttpRequest add nodejs and webworker examples for interacting with libgit2.js depends on mmap offset fix in emscripten: emscripten-core/emscripten#10095
petersalomonsen
added a commit
to petersalomonsen/libgit2
that referenced
this pull request
Dec 22, 2019
add http transport for emscripten add example for git commit fix example for git add add synchronous http worker for nodejs add web http support using sync XmlHttpRequest add nodejs and webworker examples for interacting with libgit2.js depends on mmap offset fix in emscripten: emscripten-core/emscripten#10095
petersalomonsen
force-pushed
the
fix-mmap-offset
branch
from
aaec9db
to
15f447e
Compare
petersalomonsen
added a commit
to petersalomonsen/libgit2
that referenced
this pull request
Dec 23, 2019
add http transport for emscripten add example for git commit fix example for git add add synchronous http worker for nodejs add web http support using sync XmlHttpRequest add nodejs and webworker examples for interacting with libgit2.js depends on mmap offset fix in emscripten: emscripten-core/emscripten#10095
petersalomonsen
force-pushed
the
fix-mmap-offset
branch
from
15f447e
to
e41d357
Compare
kripken
reviewed
Dec 24, 2019
There was a problem hiding this comment.
Thanks @petersalomonsen !
This looks right to me, but it's been a while since I read this code, so I might be missing something.
Perhaps you could add a test for this? Looks like https://github.com/emscripten-core/emscripten/blob/incoming/tests/fs/test_mmap.c has some msync usage (runnable with ./tests/runner.py test_fs_mmap), perhaps that can be extended a little?
petersalomonsen
force-pushed
the
fix-mmap-offset
branch
from
e41d357
to
40674f4
Compare
|
Thanks for feedback @kripken I've extended |
add and use offset parameter in doMsync add test case for shared mmap with offset fixes emscripten-core#10094
petersalomonsen
force-pushed
the
fix-mmap-offset
branch
from
40674f4
to
9e4eb22
Compare
petersalomonsen
added a commit
to petersalomonsen/libgit2
that referenced
this pull request
Dec 24, 2019
add http transport for emscripten add example for git commit fix example for git add add synchronous http worker for nodejs add web http support using sync XmlHttpRequest add nodejs and webworker examples for interacting with libgit2.js depends on mmap offset fix in emscripten: emscripten-core/emscripten#10095
kripken
approved these changes
Jan 6, 2020
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Add and use offset parameter in doMsync fixes emscripten-core#10094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10094