Fix generateDyncall when there is more than one 64 bit argument #17798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Sep 5, 2022
kripken
reviewed
Sep 6, 2022
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
kripken
reviewed
Sep 20, 2022
|
Current CI errors look like they require merging in latest |
…odmane/emscripten into generate-dyncall-multiple-bigint-args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace("j", "ii")only replaces the first "j". For some reason node has noreplaceAllso I used split + map. So the original code broke when there is more than one 64 bit argument.