ports: Skip cleaning of build directory at start of each build. NFC #17857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clear_project_build` is already called each time a new vesion of a port is extracted. There is no reason to also clear the build directory during the `create` call. This helps with #17809 and also simplifies the code in each port.
sbc100
force-pushed
the
avoid_port_clean
branch
from
65af17f
to
c7d7b22
Compare
dschuff
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clear_project_buildis already called each time a new vesion of a port is extracted. There is no reason to also clear the build directory during thecreatecall.This helps with #17809 and also simplifies the code in each port.