Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update to latest version of cicleci windows orb #21110

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 19, 2024

We got a message saying that the version vs2019 will be deprecated this year. This change doesn't stop using vs2019, but just updates to the latest version of the windows orb. We may still need to move away from vs2019 in the future, but if possible we would like to continue testing on older version of windows so that we can be sure we continue to support them.

@sbc100 sbc100 requested a review from dschuff January 19, 2024 18:19
@sbc100 sbc100 enabled auto-merge (squash) January 19, 2024 18:19
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it looks like we need to adjust the choco install command too.

We got a message saying that the version vs2019 will be deprecated this
year.  This change doesn't stop using vs2019, but just updates to the
latest version of the windows orb.  We may still need to move away from
vs2019 in the future, but if possible we would like to continue testing
on older version of windows so that we can be sure we continue to
support them.
@sbc100 sbc100 merged commit edc1a75 into emscripten-core:main Jan 19, 2024
27 checks passed
@sbc100 sbc100 deleted the update_circleci_windows branch January 19, 2024 20:06
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Jan 29, 2024
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Jan 29, 2024
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants