Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comparison in build section #1133

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Jun 21, 2024

cc @DerThorsten @h-veterinari

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this package the changes are wrong. We need playwright at runtime.

@wolfv
Copy link
Contributor Author

wolfv commented Jun 25, 2024

thanks @DerThorsten ! :)

@DerThorsten DerThorsten merged commit 69d1477 into emscripten-forge:main Jun 27, 2024
1 check failed
luizirber pushed a commit to luizirber/recipes that referenced this pull request Aug 1, 2024
* fix comparison

* Update recipe.yaml

---------

Co-authored-by: Thorsten Beier <derthorstenbeier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants