Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the setting "minimal number of cells across" >0 will partially override rules #16

Closed
wyldckat opened this issue Jul 8, 2012 · 4 comments
Assignees
Labels
Milestone

Comments

@wyldckat
Copy link
Collaborator

wyldckat commented Jul 8, 2012

Original Report:

ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
13 [enGrid] bug major always 2011-09-08 09:29 2012-03-30 10:33

Reporter: wyldckat Platform:  
Assigned To: ogloth OS:  
Priority: normal OS Version:  
Status: assigned Product Version: 1.3beta  
Product Build: Resolution: open  
Projection: none      
ETA: none  

Summary: Using the setting "minimal number of cells across" >0 will partially override rules
Description: This was detected in bug 0000009, but this seems to be a global bug, not just related to the version for Windows.

Basically, if we follow the Damper Duct tutorial until the end of the section"http://engits.eu/wiki/index.php/Tutorials/Version1.3/DamperDuct#Improve_Damper_Edges", [^] while using the global setting "minimal number of cells across" with a value of 1, the defined rules in that tutorial section will not be properly followed.

Proof is in the attached file "enGrid 1.3_beta - rules not followed.png". When the aforementioned value is 0, then the image looks like the one in the tutorial: "enGrid 1.3_beta - rules followed.png"
Steps To Reproduce:
Additional Information:
Attached Files: enGrid 1.3_beta - rules not followed.png (233 KB) 2011-09-08 09:29
enGrid 1.3_beta - rules followed.png (219 KB) 2011-09-08 09:29
@ghost ghost assigned ogloth Jul 8, 2012
@wyldckat
Copy link
Collaborator Author

wyldckat commented Jul 8, 2012

Notes

(0000036)
wyldckat  
2011-09-08 09:32  

As a result of the debugging process undertaken for the bug report 0000009, the incident was tracked down to the following for loop:

for (int i_level = 0; i_level < 3*m_MinMumCellsAcross; ++i_level) {
 foreach (vtkIdType id_node, local_nodes) {
   for (int i = 0; i < m_Part.n2nGSize(id_node); ++i) {
    local_nodes.insert(m_Part.n2nGG(id_node, i));
   }
  }
}

It's located in "libengrid/updatedesiredmeshdensity.cpp", method "void UpdateDesiredMeshDensity::operate()", a bit after the comment "// cells across branches".
The defined rules should be taken into account in this loop.


(0000068)
ogloth  
2012-03-30 10:33   I will add this to my things to do ;-)
The minimal number of cells across should really be part of the mesh settings dialogue, rather than a global option.

@wyldckat
Copy link
Collaborator Author

wyldckat commented Jul 8, 2012

Old report 0000009 is now Issue #17.

@ogloth
Copy link
Contributor

ogloth commented Sep 19, 2012

This feature has moved to the mesh settings dialogue. The global setting has no effect now.

@ogloth ogloth closed this as completed Sep 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants