Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-19326: Updates node modules' major versions #749

Closed
wants to merge 0 commits into from

Conversation

stanca-pop-lgp
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp commented Jun 27, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Agate repo and sampler have node modules that need major updates.

Resolution

For Agate root:
Updated immer dependency to v10.
There were no breaking changes affecting our code https://github.com/immerjs/immer/releases.

For Agate sampler:
Updated babel-loader dependency to v9.
There were no breaking changes affecting our code https://github.com/babel/babel-loader/releases.

Additional Considerations

For Agate I have also updated minor versions of enact/docs-utils and enact/ui-test-utils.
For sampler, minimum required node version is v14.15.0 https://github.com/babel/babel-loader/releases/tag/v9.0.0. I have also updated minor versions of enact/storybook-utils and dotenv.

Links

WRP-19326

Comments

Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d1ae055) 85.07% compared to head (d19d2c4) 85.07%.

❗ Current head d19d2c4 differs from pull request most recent head ddb260a. Consider uploading reports for the commit ddb260a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #749   +/-   ##
========================================
  Coverage    85.07%   85.07%           
========================================
  Files          120      120           
  Lines         4495     4495           
  Branches      1235     1235           
========================================
  Hits          3824     3824           
  Misses         524      524           
  Partials       147      147           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stanca-pop-lgp
Copy link
Contributor Author

Closed in favour of #750.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant