Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cache issue in levels-to-bemdecl tech #229

Closed
wants to merge 41 commits into from

Conversation

L0stSoul
Copy link
Contributor

blond and others added 30 commits March 30, 2016 11:21
The `node.getLevelNamingScheme` and the `node.setLevelNamingScheme`
methods will be removed in `enb@2.0.0`.
Got rid of scheme builders
Remove deprecated options
The `mock-fs` does not support `require` for Node.js 4.

Because of this test failed with error:

```
Cannot find module 'path/to/file.js
```
**Example of new format:**

```
{
    button__text: [
        {
            entity: { block: ‘button’, elem: ‘text’ },
            tech: ‘css’,
            path: ‘path/to/file.ext’,
            level: ‘path/to/level’
        },
        /* ... */
    ],
    /* ... */
}
```

With this introspection format to easily get a list of files named
entity.

**What has been done?**

* Use `bem-walk` to scan levels.
* Use `bem-naming` to get id of BEM entity.
* Add `BundleIntrospection` class to work with introspection of levels
for one bundle.
* Rewrite `levels` tech with `build-flow`.
* Use promises with `node.buildState` to avoid scanning the same levels
multiple times.
* Don't read files for directories (example i18n), it should do `files` tech.
Now the `bem-walk` is used to scan.
Exactly the same benchmarks in `bem-walk` repository
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.147% when pulling 049f51a on L0stSoul:ls.cache-fix into a877bed on enb:master.

@blond
Copy link
Member

blond commented Dec 3, 2016

Closed in favor of #255

@blond blond closed this Dec 3, 2016
@blond
Copy link
Member

blond commented Dec 3, 2016

Fixed in v2.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants