This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
Load components from cache when calling error hooks #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this issue was correctly identified in #490, but mistakenly characterised as "fixed". It would appear to be fixed by the change that was made to pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
on_errorhooks don't have access to the same component instances as other hooks and handlers. In addition, this may fix other resolution issues/heisenbugs but I was mainly concerned with fixingon_erroras any code right now that tries to clean up resources on error (eg. db connections) based on a component instance is probably incorrect.