ChoiceField with required=False not optional in HTML view

[brianmay]

Hello,

I have a db model containing:

action = models.CharField(max_length=4, null=True, blank=True, choices=PHOTO_ACTION, db_index=True)

ModelSerializer I believe turns this into a ChoiceField.

Unfortunately the choice list doesn't list an appropriate value to correspond with None.

I have tried setting required=False, but it has no affect.

Thanks.

[tomchristie]

Looks like we may currently support this in allow_null, but not allow_blank. We should probably support both options.

https://github.com/tomchristie/django-rest-framework/blob/master/rest_framework/templates/rest_framework/horizontal/select.html#L7

Still surprising tho as you do also have null=True on that model field.

It'd be helpful to see the serializer field it generates - could you do print(repr(MySerializer)) in the Django shell and include the output for the action field on this ticket.

[brianmay]

Unfortunately, that is not very helpful:

In [5]: print(repr(spud.serializers.PhotoSerializer))
<class 'spud.serializers.PhotoSerializer'> 

Ok, from within the program, did a print(repr(serializer.get_fields())) instead.

That gives me:

('action', ChoiceField(choices=[(u'D', u'delete'), (u'S', u'regenerate size'), (u'R', u'regenerate thumbnails'), (u'V', u'regenerate video'), (u'M', u'move photo'), (u'auto', u'rotate automatic'), (u'90', u'rotate 90 degrees clockwise'), (u'180', u'rotate 180 degrees clockwise'), (u'270', u'rotate 270 degrees clockwise')], required=False)), 

Which lists all the choices except for the None choice.

Is this what you where after?

[tomchristie]

print(repr(spud.serializers.PhotoSerializer()))

You were missing the () to instantiate the serializer. Above would have worked.

Is this what you where after?

Yes, thank you.

[tomchristie]

To do: Add allow_blank for ChoiceField, and ensure it gets mapped to from model field -> serializer field.

[jpadilla]

Working on this, but having trouble figuring out what tests should be added.