Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IPAddressField, update docs #2618

Closed
wants to merge 4 commits into from
Closed

Conversation

Ins1ne
Copy link
Contributor

@Ins1ne Ins1ne commented Feb 28, 2015

for this #1853

@jpadilla jpadilla added this to the 3.1.0 Release milestone Feb 28, 2015
@tomchristie
Copy link
Member

tomchristie commented Mar 2, 2015

Looks good! I could do with some time to review the implementation fully, simply to make sure if there are any clean-ups we can make or not, but everything else seems great.


def to_internal_value(self, data):
if data == '' and self.allow_blank:
return ''
Copy link
Contributor

@LilyFoote LilyFoote Mar 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is unnecessary. '' will always just pass though to the final return.

@tomchristie
Copy link
Member

tomchristie commented Mar 4, 2015

Going to drop the 3.1 marker on this so that I make sure to take the time to review properly. (We're about to release tomorrow, so...)

self.validators.extend(validators)

def to_internal_value(self, data):
if data and ':' in data:
Copy link
Contributor

@andreagrandi andreagrandi Mar 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but this line looks like we assume the user will always use 'both' protocol, but what happen if we can't unpack the ipv4 address to an ipv6 one? In this case ':' won't be present inside the ip string and the whole check will fail or be skipped.

Is this situation already handled by the use of ip_address_validators method? Should we add a particular test case that handle the situation where the user pass (protocol='ipv4', unpack_ipv4=True) ?

Copy link
Member

@tomchristie tomchristie Mar 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right!

@jpadilla
Copy link
Member

jpadilla commented Jun 2, 2015

Closing this in favor of #2747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants