Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct label for username field in login template #4841

Merged
merged 3 commits into from Jan 24, 2017

Conversation

mirabel-koso
Copy link
Contributor

@mirabel-koso mirabel-koso commented Jan 23, 2017

Description

Fixes #4840

Copy link
Member

@jpadilla jpadilla left a comment

Hard to tell from the assertion error but this test is failing because we went from Username: to Username, note the missing : sign.

So I'd say add the missing colon punctuation mark, like {{ form.username.label }}:.

We should also probably do the same for the password field: {{ form.password.label }}: .

@jpadilla jpadilla added the Bug label Jan 23, 2017
@jpadilla jpadilla added this to the 3.5.4 Release milestone Jan 23, 2017
@jpadilla jpadilla changed the title change username label so that whatever field the USERNAME_FIELD point… Use correct label for username field in login template Jan 23, 2017
@tomchristie tomchristie merged commit 217a81f into encode:master Jan 24, 2017
@tomchristie
Copy link
Member

tomchristie commented Jan 24, 2017

Ace, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants