Skip to content

Conversation

keturn
Copy link

@keturn keturn commented May 23, 2017

Test case refs #5160

@xordoquy
Copy link
Contributor

Grats !

… it does not change in a round-trip through the database backend.

#5160
@keturn
Copy link
Author

keturn commented May 24, 2017

I suspect the workaround I've included here, using decimal for the rounding, only works for numbers with a low exponent. That is, it works for my test case with numbers around 0.0 – 1.0, but should probably add tests for, say, 1.0e17 – 2.0e17, and 1.0e-17 – 2.0e-17.

@matteius
Copy link
Contributor

Looks like a small linting error from the CI run.

@carltongibson carltongibson added this to the 3.7.0 Release milestone Sep 25, 2017
@carltongibson
Copy link
Collaborator

Hi @keturn — I'm looking at this now.

Test only fails for Python 2.7: https://travis-ci.org/encode/django-rest-framework/builds/235041625
Is that an artefact or did Python 3 do something helpful here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants