Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing six.text_type() call on APIException.__str__ #5476

Merged
merged 1 commit into from Oct 4, 2017
Merged

Fix missing six.text_type() call on APIException.__str__ #5476

merged 1 commit into from Oct 4, 2017

Conversation

jleclanche
Copy link
Contributor

@jleclanche jleclanche commented Oct 4, 2017

The call was added in 426547c
to allow for dict-style arguments to ValidationError but does not
apply to other APIException descendants.

It is possible to hit edge cases when printing an APIException in a
custom exception handler, that was passed a non-string as its first
argument (eg. AuthenticationError({"code": "foo", "detail": "bar"}))

The call was added in 426547c
to allow for dict-style arguments to ValidationError but does not
apply to other APIException descendants.

It is possible to hit edge cases when printing an APIException in a
custom exception handler, that was passed a non-string as its first
argument (eg. AuthenticationError({"code": "foo", "detail": "bar"}))
@carltongibson carltongibson added this to the 3.7.0 Release milestone Oct 4, 2017
Copy link
Collaborator

@carltongibson carltongibson left a comment

OK, this looks fine. ("Pull up method from subclass to superclass")

Thanks! 👍

@carltongibson carltongibson merged commit cc7f4f5 into encode:master Oct 4, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants