Adjusted codecov config. #5956
Adjusted codecov config. #5956
Conversation
As per advice from @stevepeak. Closes encode#5647
|
Hi @stevepeak. Thanks for the input here! With this change I'm looking for (in particular) (Aside: These are more or less the two most important files in the project 🙂) I'm still not seeing them. Are we doing something wrong? Thanks! |
|
Both views.py and serializers.py exist in other packages, too. Might be an issue with duplicate filenames, which then get dropped for the first/main package? ("."). Other findings:
|
| @@ -5,3 +5,6 @@ coverage: | |||
| changes: false | |||
|
|
|||
| comment: off | |||
|
|
|||
| fixes: | |||
| - "::rest_framework/" | |||
There was a problem hiding this comment.
btw: why are the statuses disabled? Because of this issue?
I think it would be nice to have them reported via Github's status UI.
So this change itself should not get done probably - better not to mess with paths if not necessary. Reminded me of https://github.com/jazzband/django-configurations/pull/183/files btw, although there Well, after all pytest-cov does the equivalent of |
|
It seems to be fixed via the config in #5970: https://codecov.io/github/encode/django-rest-framework/commit/e80be12487befe8ca29cc7ddf014df0c25aa01aa |
It is useful to see if tests itself are covered after all - missing coverage there typically indicates dead/missed code paths. This also uses `source=.` and includes (with run and report), to help Codecov with reporting. Ref: encode#5956
It is useful to see if tests itself are covered after all - missing coverage there typically indicates dead/missed code paths. This also uses `source=.` and includes (with run and report), to help Codecov with reporting. Ref: #5956
It is useful to see if tests itself are covered after all - missing coverage there typically indicates dead/missed code paths. This also uses `source=.` and includes (with run and report), to help Codecov with reporting. Ref: encode#5956
As per advice from @stevepeak. Closes #5647