Skip to content

Conversation

johnthagen
Copy link
Contributor

Since Python 2.7 has been dropped, the docs can be simplified and the unnecessary object base class removed as this is default behavior in Python 3.

@jairhenrique
Copy link
Contributor

@johnthagen what do you think about removing on these files too?

rest_framework/schemas/generators.py
146:class BaseSchemaGenerator(object):

docs/api-guide/validators.md
285:    class MultipleOf(object):

docs/api-guide/fields.md
606:    class Color(object):

docs/api-guide/generic-views.md
322:    class MultipleFieldLookupMixin(object):

@johnthagen
Copy link
Contributor Author

@jairhenrique Done. If whoever merges could squash at that time through the GitHub UI, that'd be great.

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good change! if you can change the other files as well that would be really great.

@johnthagen
Copy link
Contributor Author

@auvipy I changed everything suggested by @jairhenrique. Were there other files you wanted changed?

@rpkilby
Copy link
Contributor

rpkilby commented May 14, 2020

Thanks @johnthagen!

If whoever merges could squash at that time through the GitHub UI, that'd be great.

We pretty much always use squash merge, so you're good 👍

@rpkilby rpkilby merged commit fccfdd2 into encode:master May 14, 2020
@johnthagen johnthagen deleted the patch-1 branch May 14, 2020 01:30
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants