Skip to content

Conversation

michael-k
Copy link
Contributor

The kwargs were renamed nearly 8 years ago in commit 9d8bce8 but in the docstring. Nobody ever noticed the mismatch.

There are also the newer (kw)args negotiator and parser_context. Is it worth documenting them as well?

Copy link
Contributor

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@rpkilby
Copy link
Contributor

rpkilby commented Aug 5, 2020

There are also the newer (kw)args negotiator and parser_context. Is it worth documenting them as well?

Users won't typically instantiate a request directly, so ¯\_(ツ)_/¯

@rpkilby rpkilby merged commit 0d2bbd3 into encode:master Aug 5, 2020
@michael-k michael-k deleted the docstring-naming branch August 6, 2020 07:09
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants