Fix #7706 #7724
Merged
Fix #7706 #7724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle non-dict values for NestedSerializer during BrowsableAPI rendering.
6 tasks
Closed
|
Seems okay, yup. Thanks! |
stefanacin
pushed a commit
to stefanacin/django-rest-framework
that referenced
this pull request
Mar 22, 2021
Handle non-dict values for NestedSerializer during BrowsableAPI rendering.
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Handle non-dict values for NestedSerializer during BrowsableAPI rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle non-dict values for NestedSerializer during BrowsableAPI rendering.
Description
This PR is created in order to fix issue #7706. When a value that is not a Mappable is provided to a nested serializer, the rendering of NestedBoundField, which takes place for Browsable API, ends up in an error, which is not caught. Here, the suggested solution is to an empty
dictif it is not an instance of anyMappablesuch asdict. Since the data is not valid and the validation error is not a field-specific error, I did not try to find a solution to show it in theHTML formin browsable API. Instead, I decided not to show that error in theHTML formand to convert the data to an emptydictsince it cannot be properly shown on theHTML form.fix #7706
refs #7706