Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of models api #1284

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Refactoring of models api #1284

merged 3 commits into from
Sep 14, 2020

Conversation

cdeler
Copy link
Member

@cdeler cdeler commented Sep 11, 2020

Having working on #1275 in #1280, I've got a reasonable comment (from @StephenBrown2) that the PR could be split into several one to reduce problems with review.

In this PR I:

  1. made Request.prepare private
  2. Changed QueryParamTypes so that QueryParams accepts bytes

@cdeler
Copy link
Member Author

cdeler commented Sep 11, 2020 •
edited
Loading

Pipeline will be fixed by the #1283
Done

@cdeler cdeler requested a review from a team September 12, 2020 18:05
tomchristie
tomchristie approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomchristie tomchristie merged commit 62c6c1c into encode:master Sep 14, 2020
@cdeler cdeler deleted the refactoring-of-models-api branch September 14, 2020 11:19
@cdeler cdeler mentioned this pull request Sep 14, 2020
Closed
@tomchristie tomchristie mentioned this pull request Sep 21, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdeler @tomchristie