PPC: Reimplement pooled data reference calculation #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplements encounter#140 The relocations are now generated when the object is first read in `parse`, right after the real relocations are read. `resolve_relocation` was changed to take `obj.symbols` instead of `obj` as an argument, because `obj` itself doesn't exist yet at the time the relocations are being read.
…addend This is a regression that was introduced by encounter#158 diffing addends in addition to symbol names. But it's not really a bug in that PR, rather it seems like I simply never added the offset into the addend when creating a fake pool relocation for an extern symbol. So this commit fixes that root issue instead.
LagoLunatic
commented
Mar 5, 2025
| @@ -64,10 +64,10 @@ fn reloc_eq( | |||
|
|
|||
| #[inline] | |||
| pub fn resolve_relocation<'obj>( | |||
| obj: &'obj Object, | |||
| symbols: &'obj [Symbol], | |||
There was a problem hiding this comment.
I wasn't sure, does this 'obj lifetime stuff need updating since obj: &Object isn't being passed to this function now?
There was a problem hiding this comment.
This is fine, the lifetime name still makes sense too.
| @@ -194,6 +194,13 @@ | |||
| "name": "Register '$' prefix", | |||
| "description": "Display MIPS register names with a '$' prefix." | |||
| }, | |||
| { | |||
| "id": "ppc.calculatePoolRelocations", | |||
There was a problem hiding this comment.
For now I made this a PPC arch specific option since it only affects PPC, though I'd still like to implement this for ARM too in the future, so I guess this can be renamed to a general option "calculatePoolRelocations" later on once it exists for more arches. Alternatively we could make it general right now.
There was a problem hiding this comment.
Let’s leave it specific to PPC for now
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#140 PPC: Display data values on hover for pools as well
Also adds a new option to disable this calculation for performance (it defaults to calculating them):
Also fixes a bug in how extern relocation addends were being treated that was first introduced in #153, but which only became very noticeable when addend diffing was added in #158.