More mips reloc support #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encounter
approved these changes
Sep 21, 2022
| ObjRelocKind::MipsHi16 | ObjRelocKind::MipsLo16 => { | ||
| (addend & 0x0000FFFF) * 4 | ||
| } | ||
| ObjRelocKind::Mips32 => addend * 4, |
There was a problem hiding this comment.
These multiplications by 4 don't make sense to me, outside of the Mips26 case where it is indeed right
(also lo16/hi16 need to be joined together and lo16 relocations are s16's; maybe that's handled elsewhere or a todo for now though)
There was a problem hiding this comment.
Thanks for the info, I'll check some MIPS objects to figure out what's proper here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right way to handle particularly the absolute ones, but I needed these to get it to build the mips objects I was testing it on correctly.