Improve loading screen translation loading #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't have a translation matching any regional locale in `navigator.languages`, try again with only the locale's language. This will allow better fallbacks when the browser doesn't build `navigator.languages` as a fallback list itself like `['es-GT', 'es-419', 'es']`.
This allows matching a much wider set of locales without depending on the browser to build `navigator.languages` as we expect it. Furthermore, we're not actually providing regional translation variation and probably never will. Fixes: #893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to regionless locale matching and make our existing translation IDs regionless. This makes it much more likely that a Spanish translation will be used without depending on the browser to setup
navigator.languagesexactly as we expect. I tested this in Chrome overridingnavigator.languagesto['es-MX']and it DTRT.Fixes: #893