-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Product Logo in sidebar #283
Comments
Thanks for opening your first issue here! Be sure to follow the issue template! |
I have mentioned as svg which will help us to decide its resolution without losing its quality while rendering |
also we can use same svg with rendering it as 32x32 in site-nav part so it will help people to select tools much easier |
https://simpleicons.org/ is a good source of CC0 SVG icons, they're also used by https://shields.io/ |
Simpleicons looks neat. I was also thinking of incorporating icons in the generated visual timeline (small icon at bottom right of the timeline). Are SVG icons usable as Favicons? Should we use product icons for favicons? |
yes almost all browser support svg for favicons , but i believe
keeping the endoflife's its own favicon same for all pages is a better idea.
…On Mon, Jul 5, 2021, 16:12 Nemo ***@***.***> wrote:
Simpleicons looks neat. I was also thinking of incorporating icons in the
generated visual timeline (small icon at bottom right of the timeline).
Are SVG icons usable as Favicons? Should we use product icons for favicons?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3R4RXV7P7SIJEM6ZAQPLTWGVSFANCNFSM472OHFGQ>
.
|
I normally dont want to be "That" guy who always willing to be "grammar nazi" |
Thanks for the note, will take care of it. |
I think this one ^^ have forgotten :) |
If you're working on this, you will need to extend the nav.html file as a include in our repository from the theme we are using: https://github.com/pmarsceill/just-the-docs/blob/master/_includes/nav.html. Then, add the relevant HTML/CSS to add the icon to the sidebar to display the icon correctly. Make sure the design looks good (and well-aligned) even if we don't have an icon for the product. See the icon bits in our product page template: endoflife.date/_layouts/post.html Lines 205 to 209 in 53b9a6f
Read through very helpful guide for new contributors during Hacktoberfest as well to understand how to setup the project. |
Sir, can I work on this issue |
Go ahead, thanks for letting us know 👍🏽 |
hey! , I would be happy to help. |
looks like history repeats itself , first @sooraj-gk then @ampsteric |
It will be nice to add a new part for tools sections called productLogo or logo so
we can put logos with svg formated logo links ( which must be creative common or any open license) that will improve its look visually
The text was updated successfully, but these errors were encountered: