-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Product] Amazon Corretto #2423
Conversation
194cf1a
to
6339681
Compare
Co-authored-by: Nemo <commits@captnemo.in>
6339681
to
636ec70
Compare
@captn3m0, ready for a new review : https://deploy-preview-2423--endoflife-date.netlify.app/amazon-corretto. |
Triggered automation here: https://github.com/endoflife-date/release-data/actions/runs/4124963506 (created branch of the same name). Made a few small changes in wording. Should be good to merge after validating the picked up versions. |
It ran for a while, but didn't pick up any versions:
|
I suspect the standard regex did not work with versions such as |
Got it working after a few attempts: endoflife-date/release-data@90eecd5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
👏 |
Closes #2334. See also #364.