Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Product] Amazon Corretto #2423

Merged
merged 5 commits into from
Feb 8, 2023
Merged

[New Product] Amazon Corretto #2423

merged 5 commits into from
Feb 8, 2023

Conversation

marcwrobel
Copy link
Member

Closes #2334. See also #364.

@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Jan 31, 2023
Co-authored-by: Nemo <commits@captnemo.in>
@marcwrobel
Copy link
Member Author

@captn3m0
Copy link
Member

captn3m0 commented Feb 8, 2023

Triggered automation here: https://github.com/endoflife-date/release-data/actions/runs/4124963506 (created branch of the same name).

Made a few small changes in wording. Should be good to merge after validating the picked up versions.

@captn3m0
Copy link
Member

captn3m0 commented Feb 8, 2023

It ran for a while, but didn't pick up any versions:

2023-02-08T14:12:53.9246849Z ##[group]amazon-corretto
2023-02-08T14:13:04.1933875Z ##[endgroup]

@marcwrobel
Copy link
Member Author

It ran for a while, but didn't pick up any versions:

I suspect the standard regex did not work with versions such as 19.0.2.7.1. Will have a look later.

@captn3m0
Copy link
Member

captn3m0 commented Feb 8, 2023

@captn3m0
Copy link
Member

captn3m0 commented Feb 8, 2023

Got it working after a few attempts: endoflife-date/release-data@90eecd5

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@adriens
Copy link
Contributor

adriens commented Feb 8, 2023

👏

@marcwrobel marcwrobel merged commit 7cca161 into master Feb 8, 2023
@marcwrobel marcwrobel deleted the add-amazon-corretto branch February 8, 2023 23:20
@adriens
Copy link
Contributor

adriens commented Feb 9, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request - Product] Amazon Corretto
3 participants