Support JSON API 1.0. #14
Conversation
|
Yeah - the |
|
Random newbie Ember Data question: I read on the ember data issue tracker that it plans on supporting json api out of the box. Does this mean that this adapter will not be required or is it somehow specific for jsonapi-resources? |
|
I asked about out-of-the-box support for JSON API on the Ember Slack channel yesterday, and they confirmed that that was the plan. But, I don't know any more specifics. I assume/hope that this library won't be necessary once it's the default. |
| }); | ||
| }); | ||
| }); | ||
| // var get = Ember.get, set = Ember.set; |
There was a problem hiding this comment.
Why is this whole file commented out?
There was a problem hiding this comment.
Shouldn't have been I don't think. I probably just forgot to add it back as I worked through the issues.
|
@barelyknown please checkout my comments. Be sure to test with I'm currently upgrading my server to be 1.0 compliant. I'll verify this build with my server for additional tests. |
|
I haven't looked at this in about a week, but I should later this week. Since ember-data is planning on shipping a JSON API 1.0 compliant serializer and adapter shortly (I just noticed that it was merged into master ~2 days ago), do you plan on maintaining this? |
|
It'd be good to ship this asap. Otherwise we'll have to cope with the unlucky current situation where the spec is in v1.0, ember data is far from shipping (see emberjs/data/issues/2905), and ember-json-api supports only an outdated, non standard version. This can break apps anywhere 👎 |
|
|
|
This could be opened against the main repo, specially now that @eneuhauser is a core member |
|
I hate to be this guy but +1. We should get this merged against the main repo. |
I removed the extract links tests (they're no longer relevant) and made the rest of the tests pass. I didn't refactor much, but it looks like there is a decent amount of code that is no longer necessary. I also think that the normalize and serialize flow is strange as is (I probably should have rewritten the normalize method but didn't have time to dig in to understand enough about how the library works).
I'd be happy to clean it up more if you'd like (once I have time), or feel free to take it and run with it.