Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript #1819

Merged
merged 52 commits into from
May 4, 2020
Merged

TypeScript #1819

merged 52 commits into from
May 4, 2020

Conversation

kapnobatai137
Copy link
Contributor

New topic on TypeScript.

@enki-hq
Copy link
Collaborator

enki-hq commented Mar 5, 2020

Insight previews:

@enki-hq

This comment has been minimized.

@enki-hq

This comment has been minimized.

@enki-hq

This comment has been minimized.

@enki-hq

This comment has been minimized.

typescript/README.md Outdated Show resolved Hide resolved
Copy link
Member

@loopiezlol loopiezlol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig the last TS push - explanations are more clear and concise, it's a breeze to go through them

had a few comments here and there tho

}

??? EnkiApp ??? MobileApp {
category: ???
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get from the insight that you have to do category: string = 'Education'

also, why wouldn't just category.string not work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on purpose.

There's even a hint in the code :)

It doesn't work because we're calling new EnkiApp(); and never set the category.

Screen Shot 2020-05-01 at 11 09 09 AM

Copy link
Member

@nem035 nem035 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was explained in the insight about classes.

The kind field on the class Animal has a default value.

I'll elaborate on it a bit more in that insight then.

@enki-hq
Copy link
Collaborator

enki-hq commented May 1, 2020

Rule insight:footnotes failed for files:

  • typescript/introduction/tsc-basic-types/tsc-object-type-comparison.md

…ean.md

Co-authored-by: Andrei Calabangiu <andrei@enki.com>
@enki-hq
Copy link
Collaborator

enki-hq commented May 1, 2020

Rule insight:footnotes failed for files:

  • typescript/introduction/tsc-basic-types/tsc-object-type-comparison.md

1 similar comment
@enki-hq
Copy link
Collaborator

enki-hq commented May 1, 2020

Rule insight:footnotes failed for files:

  • typescript/introduction/tsc-basic-types/tsc-object-type-comparison.md

@enki-hq
Copy link
Collaborator

enki-hq commented May 1, 2020

Rule insight:footnotes failed for files:

  • typescript/introduction/tsc-basic-types/tsc-object-type-comparison.md

@enki-hq
Copy link
Collaborator

enki-hq commented May 1, 2020

Rule insight:footnotes failed for files:

  • typescript/introduction/tsc-basic-types/tsc-object-type-comparison.md

@kapnobatai137 kapnobatai137 merged commit 9257c0e into master May 4, 2020
@kapnobatai137 kapnobatai137 deleted the typescript branch May 4, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants