Module for monitoring miners speed on NiceHash.com #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facetoe
reviewed
Dec 3, 2017
| _api_query_interval = 3 | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super(NiceHashSpeed, self).__init__(*args, **kwargs) |
There was a problem hiding this comment.
It's better to use the provided init method in the base class than __init__ as some housekeeping is done before the module is initialized.
facetoe
reviewed
Dec 3, 2017
|
|
||
| :return: Return JSON data with statistic information about miners | ||
| """ | ||
| with open('/tmp/nhapi.json', 'w+') as f: |
There was a problem hiding this comment.
Do you really need to write out the fetch_date_time to a file? You could just cache it in memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm closed previous PR #621 and create new with only NiceHash module.
I will be happy with the positive decision :-)