Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port IDE support for SKIP and FREEZE to new AST #5572

Closed
kazcw opened this issue Feb 7, 2023 · 2 comments
Closed

Port IDE support for SKIP and FREEZE to new AST #5572

kazcw opened this issue Feb 7, 2023 · 2 comments
Assignees
@kazcw
Labels
--regression Important: regression -parser

Comments

@kazcw
Copy link
Contributor

kazcw commented Feb 7, 2023 •
edited by jdunkerley
Loading

General Summary

The logic for adding/removing/detecting SKIP and FREEZE applications in the gui needs to be rewritten for their new representations.

Motivation

This is necessary for SKIP and FREEZE to work.
@kazcw kazcw added -parser --regression Important: regression labels Feb 7, 2023
@kazcw kazcw self-assigned this Feb 7, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 7, 2023
@kazcw kazcw mentioned this issue Feb 7, 2023
Merged
4 tasks
@kazcw kazcw moved this from ❓New to 📤 Backlog in Issues Board Feb 7, 2023
@jdunkerley jdunkerley changed the title Port IDE support for SPAN and FREEZE to new AST Port IDE support for SKIP and FREEZE to new AST Feb 10, 2023
@jdunkerley
Copy link
Member

SKIP and FREEZE are not expected in the beta release version, so removing from the backlog for now.

mergify bot pushed a commit that referenced this issue Feb 10, 2023
@kazcw
Port graph editor to new AST (#4113)
d1af257 
Use the Rust parser rather than the Scala parser to parse Enso code in the IDE.

Implements:
- https://www.pivotaltracker.com/story/show/182975925
- https://www.pivotaltracker.com/story/show/182988419
- https://www.pivotaltracker.com/story/show/182970096
- https://www.pivotaltracker.com/story/show/182973659
- https://www.pivotaltracker.com/story/show/182974161
- https://www.pivotaltracker.com/story/show/182974205

There is additional functionality needed before the transition is fully-completed, however I think it's time for this to see review and testing, so I've opened separate issues. In rough order of urgency (these issues are also linked from the corresponding disabled tests):
- #5573
- #5571
- #5572
- #5574

# Important Notes
The implementation is based partly on translation, and partly on new analysis. Method- and operator-related shapes are translated to the old `Ast` variants, so that all the analysis applied to them doesn't need to be ported at this time. Everything else (mostly "macros" in the old AST) is implemented with new analysis.
@vitvakatu vitvakatu mentioned this issue Mar 31, 2023
Merged
5 tasks
@kazcw
Copy link
Contributor Author

kazcw commented Oct 29, 2024

I'm going to close this; when we plan a new implementation of SKIP/FREEZE, we will create the necessary issues.

@kazcw kazcw closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
--regression Important: regression -parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kazcw @jdunkerley