Full support for disable-comments in IDE #5573
Comments
|
Implemented in #4113 |
mergify bot
pushed a commit
that referenced
this issue
Feb 10, 2023
Use the Rust parser rather than the Scala parser to parse Enso code in the IDE. Implements: - https://www.pivotaltracker.com/story/show/182975925 - https://www.pivotaltracker.com/story/show/182988419 - https://www.pivotaltracker.com/story/show/182970096 - https://www.pivotaltracker.com/story/show/182973659 - https://www.pivotaltracker.com/story/show/182974161 - https://www.pivotaltracker.com/story/show/182974205 There is additional functionality needed before the transition is fully-completed, however I think it's time for this to see review and testing, so I've opened separate issues. In rough order of urgency (these issues are also linked from the corresponding disabled tests): - #5573 - #5571 - #5572 - #5574 # Important Notes The implementation is based partly on translation, and partly on new analysis. Method- and operator-related shapes are translated to the old `Ast` variants, so that all the analysis applied to them doesn't need to be ported at this time. Everything else (mostly "macros" in the old AST) is implemented with new analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
General Summary
The new parser /
tree_to_astdoesn't preserve disable-comments in some locations (e.g. if they occur in a line after an expression).Motivation
Support disable-comments everywhere to avoid loss of commented text.
The text was updated successfully, but these errors were encountered: