Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A drop-down that allows changing the execution mode. #5931

Closed
Tracked by #5899
vitvakatu opened this issue Mar 14, 2023 · 8 comments
Closed
Tracked by #5899

A drop-down that allows changing the execution mode. #5931

vitvakatu opened this issue Mar 14, 2023 · 8 comments
Assignees
Labels
d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Mar 14, 2023

A currently active execution mode should be displayed in the top-left corner of the IDE.

After clicking on it, a drop-down should be displayed to switch the execution mode.

The design of the label and dropdown should be similar to Figma. We can't do the same design yet, because it requires a lot of changes in the top-bar components. The dropdown should be placed to the left of the project name so that it's position is not affected by the breadcrumbs.

image

This is a task about visual part of the dropdown, but a basic integration with the controller side is in scope. (with mocks if the controller side is not ready yet) We should use a dropdown widget component that is already available in the IDE.

QA Acceptance Criteria

GIVEN The interface debug scene is opened
THEN I see a current execution mode in the top-left corner of the screen
WHEN I click on the label
THEN I see a dropdown with all the possible execution modes
WHEN I select an item from the dropdown
THEN The label displays a selected mode now
AND The dropdown is closed
@vitvakatu vitvakatu added d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint -gui labels Mar 14, 2023
@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Mar 14, 2023
@vitvakatu vitvakatu added this to the Design Partners milestone Mar 14, 2023
@MichaelMauderer MichaelMauderer moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 16, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 21, 2023

Michael Mauderer reports a new STANDUP for the provided date (2023-03-22):

Progress: I set up the demo scene and reviewed the current Dropdown implementation. Started implementing a new component that will wrap the Dropdown and add the preview of the selection etc. It should be finished by 2023-03-24.

Next Day: Next day I will be working on the #5931 task. Extend the demo scene with visuals and functionality from the specification.

@enso-bot
Copy link

enso-bot bot commented Mar 22, 2023

Michael Mauderer reports a new STANDUP for today (2023-03-22):

Progress: Worked on refactoring some parts of the current DropDownMenu to make it fit for the current use case. Started implementing the "ExecutionModeSelector", a new component that wraps the DropDownMenu and will add the required design elements and additional functionality (i.e., play button). It should be finished by 2023-03-24.

Next Day: Next day I will be working on the #5931 task. Finish implementation of ExecutionModeSelector.

@enso-bot
Copy link

enso-bot bot commented Mar 23, 2023

Michael Mauderer reports a new STANDUP for today (2023-03-23):

Progress: Continued work on the visuals and API of the DropDownMenu, creating all shapes, interactive elements and placing them in the demo scene. It should be finished by 2023-03-24.

Next Day: Next day I will be working on the #5931 task. Finish hooking up all FRP endpoints, and create some dummy logs outputs for showcase. Open PR.

@enso-bot
Copy link

enso-bot bot commented Mar 26, 2023

Michael Mauderer reports a new STANDUP for the provided date (2023-03-24):

Progress: Finished work on the visual part of the dropdown (with FRP API) and started the mock integration with the controller. It should be finished by 2023-03-24.

Next Day: Next day I will be working on the #5931 task. Finish work on the mock API and demo scene integration.

@enso-bot
Copy link

enso-bot bot commented Mar 28, 2023

Michael Mauderer reports a new 🔴 DELAY for yesterday (2023-03-27):

Summary: There is 4 days delay in implementation of the A drop-down that allows changing the execution mode. (#5931) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days weekend.

Delay Cause: Resolving some issues related to the current setup of the breadcrumbs and the depth ordering of the dropdownmenu when used in the panel layer.

@enso-bot
Copy link

enso-bot bot commented Mar 28, 2023

Michael Mauderer reports a new STANDUP for yesterday (2023-03-27):

Progress: Worked on integration. Found some issues with the integration in the graph editor related to the layering of the dropdown menu and of the breadcrumbs background, which is currently used to cover the window controls that appear in some environments. It should be finished by 2023-03-28.

Next Day: Next day I will be working on the #5931 task. Fix the layering and layout issue.

@enso-bot
Copy link

enso-bot bot commented Mar 28, 2023

Michael Mauderer reports a new STANDUP for today (2023-03-28):

Progress: Fixed the layering issue and added a new option to the dropdown for changing the alignment of the label text. Started cleaning code for PR. It should be finished by 2023-03-28.

Next Day: Next day I will be working on the #5931 task. Open PR and start on next task.

@MichaelMauderer MichaelMauderer moved this from 🔧 Implementation to 👁️ Code review in Issues Board Mar 29, 2023
@farmaazon farmaazon moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Apr 12, 2023
@MichaelMauderer MichaelMauderer moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Apr 12, 2023
mergify bot pushed a commit that referenced this issue Apr 18, 2023
@vitvakatu
Copy link
Contributor Author

Implemented in #6130

@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Projects
Archived in project
Development

No branches or pull requests

2 participants