Markdown formatting toolbar #10064
Closed
Markdown formatting toolbar #10064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormatting-toolbar
ExtendedMenu. - DropdownMenu: Encapsulates the dropdown pattern, i.e. a toggle button that opens a floating pane. - MenuButton: A low-level control that adds button behavior to any element; all other buttons are now implemented using it.
kazcw
added
the
CI: No changelog needed
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
Frizi
reviewed
May 24, 2024
Comment on lines
225
to
230
| return computed({ | ||
| get: () => state.value, | ||
| set: (value) => { | ||
| if (value !== state.value) editor.update($setBlockType[value]) | ||
| }, | ||
| }) |
There was a problem hiding this comment.
This is a weird pattern, having side effects in the computed setter. Why not return the state here, and create a watcher to run the update?
|
Merged in #10205. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Render markdown image syntax in documentation. Relative URLs are fetched from the project directory; absolute URLs are hotlinked from wherever they point. Syntax and URL resolution: ``` # In New_Project27/src/Main.enso ## Main method docs - Image at `New_Project27/src/image.jpg`:  - Image at `New_Project27/image.png`:  - Image at `New_Project27/src/image.jpg`:  - Image at `New_Project27/image.png`:  main = 42 ``` https://github.com/enso-org/enso/assets/1047859/3f873f3f-31b1-44bf-ae3e-2f467f2d546d Closes #10058. # Important Notes Stacked on #10064.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implement the primary formatting toolbar for the Markdown editor.
Important Notes
Stacked on #10027, #10063.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.