Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added compare_to to True/False #3317

Merged
merged 7 commits into from
Mar 8, 2022
Merged

Added compare_to to True/False #3317

merged 7 commits into from
Mar 8, 2022

Conversation

hubertp
Copy link
Contributor

@hubertp hubertp commented Mar 3, 2022

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181030200

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

jdunkerley
jdunkerley requested changes Mar 3, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some API update to avoid more deprecated calls but other LGTM

...e/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/bool/CompareToNode.java Outdated Show resolved Hide resolved
...e/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/bool/CompareToNode.java Outdated Show resolved Hide resolved
@hubertp hubertp force-pushed the wip/hubert/bool-compareto-181030200 branch from 0039746 to 6b48f46 Compare March 4, 2022 14:34
@hubertp hubertp requested a review from jdunkerley March 4, 2022 14:58
@jdunkerley
Copy link
Member

LGTM

@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2022
@jdunkerley
Copy link
Member

Should probably have a changelog entry added

@hubertp hubertp removed the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2022
@hubertp
Copy link
Contributor Author

hubertp commented Mar 7, 2022

@4e6 Looks like this one requires 👍 from you as well?

@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label Mar 8, 2022
@mwu-tow mwu-tow merged commit f921081 into enso-org:develop Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdanilo wdanilo wdanilo left review comments

@kustosz kustosz kustosz left review comments

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 4e6 approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hubertp @jdunkerley @4e6 @kustosz @wdanilo @mwu-tow