Cleanup Ref - get/put #3457
Merged
Cleanup Ref - get/put #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
requested review from
4e6,
jdunkerley,
radeusgd,
JaroslavTulach,
MichaelMauderer,
wdanilo and
farmaazon
as code owners
hubertp
force-pushed
the
wip/hubert/update-ref-182138899
branch
from
28935c2
to
01fd221
Compare
jdunkerley
reviewed
May 16, 2022
app/gui/view/graph-editor/src/builtin/visualization/native/inc/error_preprocessor.enso
Outdated
Show resolved
Hide resolved
JaroslavTulach
approved these changes
May 16, 2022
The change promotes static methods of `Ref`, `get` and `put`, to be methods of `Ref` type. The change also removes `Ref` module from the default namespace. Had to mostly c&p functional dispatch for now, in order for the methods to be found. Will auto-generate that code as part of builtins system. Related to https://www.pivotaltracker.com/story/show/182138899
Solution proposed by @4e6. Can't write `Standard.Base.Runtime.Ref.new` or import the module in that lambda so this is the only sensible solution.
hubertp
force-pushed
the
wip/hubert/update-ref-182138899
branch
from
8753639
to
785f19e
Compare
jdunkerley
approved these changes
May 16, 2022
4e6
approved these changes
May 17, 2022
radeusgd
approved these changes
May 17, 2022
MichaelMauderer
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The change promotes static methods of
Ref,getandput, to bemethods of
Reftype.The change also removes
Refmodule from the default namespace.Had to mostly c&p functional dispatch for now, in order for the methods
to be found. Will auto-generate that code as part of builtins system.
Related to https://www.pivotaltracker.com/story/show/182138899
Checklist
Please include the following checklist in your PR:
./run distand./run watch.