Add support for .pgpass to PostgreSQL
#3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/postgres-pgpass-182582924
branch
from
9fd1abc
to
a491c04
Compare
radeusgd
requested review from
4e6,
jdunkerley and
JaroslavTulach
as code owners
hubertp
approved these changes
Jul 19, 2022
| - default: The default fallback value. | ||
|
|
||
| > Example | ||
| Look up the value of the `FOOBAR` environment variable. |
There was a problem hiding this comment.
Let's maybe use something more common in stdlib documentation like HOME ;)
|
|
||
| /** | ||
| * Overrides the System environment variable with a new value. The override is only visible from | ||
| * within Enso. |
There was a problem hiding this comment.
Maybe mention that it is not persisted?
hubertp
reviewed
Jul 19, 2022
| The environment variable override is only visible to the Enso | ||
| `Environment.get` method, the environment as seen from a direct | ||
| `System.getenv` Java call remains unchanged. | ||
| unsafe_with_environment_override : Text -> Text -> Any -> Any |
There was a problem hiding this comment.
Maybe this should be an extension method in Test?
There was a problem hiding this comment.
Definitely! That sounds like a much better place for it, as I was quite hesitant putting it in Base.
There was a problem hiding this comment.
I moved it, does it look good now?
jdunkerley
requested changes
Jul 19, 2022
engine/runtime/src/main/java/org/enso/interpreter/runtime/system/System.java
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/System/File/Posix_File_Permission.enso
Outdated
Show resolved
Hide resolved
radeusgd
force-pushed
the
wip/radeusgd/postgres-pgpass-182582924
branch
from
eb238f0
to
4688314
Compare
WIP - some minor fixes still pending
jdunkerley
approved these changes
Jul 19, 2022
radeusgd
force-pushed
the
wip/radeusgd/postgres-pgpass-182582924
branch
from
1a15676
to
a4b57b2
Compare
radeusgd
added
CI: Ready to merge
JaroslavTulach
approved these changes
Jul 20, 2022
distribution/lib/Standard/Base/0.0.0-dev/src/System/File/File_Permissions.enso
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Postgres/Pgpass.enso
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/data/EnsoFile.java
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/System/File/File_Permissions.enso
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/182582924
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.