Add Linear Regression support for Vectors. #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
force-pushed
the
wip/jd/linear-regression-functions-182060056
branch
from
22c3acf
to
d10e5cb
Compare
|
Spreadsheet used to create test data: |
radeusgd
reviewed
Jul 21, 2022
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Regression.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Regression.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Regression.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Regression.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Regression.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Regression.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Regression.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Jul 21, 2022
std-bits/base/src/main/java/org/enso/base/statistics/FitError.java
Outdated
Show resolved
Hide resolved
std-bits/base/src/main/java/org/enso/base/statistics/LinearModel.java
Outdated
Show resolved
Hide resolved
std-bits/base/src/main/java/org/enso/base/statistics/Regression.java
Outdated
Show resolved
Hide resolved
std-bits/base/src/main/java/org/enso/base/statistics/CorrelationStatistics.java
Show resolved
Hide resolved
radeusgd
approved these changes
Jul 21, 2022
jdunkerley
force-pushed
the
wip/jd/linear-regression-functions-182060056
branch
from
e0b2a55
to
57c7932
Compare
|
|
||
| ## Use Least Squares to fit a line to the data. | ||
| fit_least_squares : Vector -> Vector -> Model -> Fitted_Model ! Illegal_Argument_Error | Fit_Error | ||
| fit_least_squares known_xs known_ys model=Linear_Model = |
There was a problem hiding this comment.
I was wondering how one can do a linear regression on a single Vector!? But there are two!
There was a problem hiding this comment.
fit_least_squares (input.map _.first) (input.map _.second) would be one way to achieve this.
|
|
||
| Test.specify "predict values on a power trend line" <| | ||
| known_xs = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] | ||
| known_ys = [0.26128, 0.28144, 0.26353, 0.30247, 0.28677, 0.23992, 0.30586, 0.32785, 0.26324, 0.3411] |
There was a problem hiding this comment.
I would rather expect zipped array or array and a function - unless this comes from two columns in a table, right?
There was a problem hiding this comment.
Expect it to come from 2 columns in a table In due course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds least squares regression APIs. Covers the basic 4 trend line types from Excel (doesn't cover Polynomial or Moving Average).
Removes the old
Modelfrom theStandard.Table.Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.