-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling exceptions in IDE main to avoid entering "zombie process" state. #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+510
to
+517
// It is critical that the main function runs in its entirety. Otherwise, IDE enters a "zombie | ||
// process" state, where Electron processes have been spawned, but there is no window and user can't | ||
// observe anything. Usually they will try to spawn another instance of the IDE, but this can fail | ||
// because of these zombie process presence. | ||
// | ||
// The solution is to catch all errors and exit the process if any part of the initial setup fails. | ||
// If it succeeds, at least the Window will be shown, allowing the user to observe the error and | ||
// close it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// It is critical that the main function runs in its entirety. Otherwise, IDE enters a "zombie | |
// process" state, where Electron processes have been spawned, but there is no window and user can't | |
// observe anything. Usually they will try to spawn another instance of the IDE, but this can fail | |
// because of these zombie process presence. | |
// | |
// The solution is to catch all errors and exit the process if any part of the initial setup fails. | |
// If it succeeds, at least the Window will be shown, allowing the user to observe the error and | |
// close it. | |
// It is critical that the main function runs in its entirety. Otherwise, IDE enters a "zombie | |
// process" state, where Electron processes have been spawned, but there is no window and the user can't | |
// observe anything. Usually, they will try to spawn another instance of the IDE, but this can fail | |
// because of these zombie process presence. | |
// | |
// The solution is to catch all errors and exit the process if any part of the initial setup fails. | |
// If it succeeds, at least the window will be shown, allowing the user to observe the error and | |
// close it. |
MichaelMauderer
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is meant to address https://www.pivotaltracker.com/story/show/182691027.
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.