Enable Junit reports for Scalatest #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
changed the title
4e6
force-pushed
the
wip/db/scalatest-junit-report
branch
4 times, most recently
from
a732fc3
to
6bfe4b5
Compare
This reverts commit 3f9b1f5.
4e6
force-pushed
the
wip/db/scalatest-junit-report
branch
from
99d9131
to
d579b00
Compare
4e6
requested review from
jdunkerley,
radeusgd,
JaroslavTulach and
hubertp
as code owners
mwu-tow
approved these changes
Oct 6, 2022
hubertp
approved these changes
Oct 6, 2022
| Seq(Tests.Argument("-oI")) ++ | ||
| sys.env | ||
| .get("ENSO_TEST_JUNIT_DIR") | ||
| .map { junitDir => |
There was a problem hiding this comment.
This compiles? I would expect Seq vs Option mismatch
There was a problem hiding this comment.
I think it's because, Option is an Iterable, and can be accepted by ++ method
There was a problem hiding this comment.
Yes, it's an IterableOnce in fact https://www.scala-lang.org/api/2.13.9/scala/Option.html
radeusgd
reviewed
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci no changelog needed]
Pull Request Description
Changelog
Important Notes
Sometimes the report is created on a different workflow, like here. Turned out it is a known issue in GitHub Actions https://github.com/orgs/community/discussions/24616
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
Unit tests have been written where possible.If GUI codebase was changed: Enso GUI was tested when built using BOTH
./run ide buildand./run ide watch.