Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filtering by Filter_Condition to Vector, Range and List #3770

Merged
merged 10 commits into from
Oct 7, 2022
Merged

Add filtering by Filter_Condition to Vector, Range and List #3770

merged 10 commits into from
Oct 7, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Oct 5, 2022

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/183389901

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@radeusgd radeusgd self-assigned this Oct 5, 2022
@radeusgd radeusgd requested a review from hubertp October 5, 2022 22:32
@radeusgd radeusgd force-pushed the wip/radeusgd/base-types-filter-condition-183389901 branch 3 times, most recently from e6c9390 to 058e552 Compare October 6, 2022 14:31
jdunkerley
jdunkerley approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - added a couple of suggestions.

@radeusgd radeusgd force-pushed the wip/radeusgd/base-types-filter-condition-183389901 branch from 058e552 to c8676cd Compare October 6, 2022 17:58
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Oct 6, 2022
@mergify mergify bot merged commit 7afaf8c into develop Oct 7, 2022
@mergify mergify bot deleted the wip/radeusgd/base-types-filter-condition-183389901 branch October 7, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@hubertp hubertp Awaiting requested review from hubertp

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @jdunkerley